Repository navigation
Conversation
prk-Jr
changed the base branch from
spec/482-axum-geo-manifest-binding
to
feature/kv-geoip
November 18, 2026 14:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ctx.geo()coverage with Cloudflare request metadata and Spin lookup against an explicitly pinned KV dataset.Stacked on #454 (
feature/kv-geoip), which already includes #502. The portable KV reader and Axum foundation are supplied by those parents.Changes
edgezero-adapter-spinedgezero-coreedgezero-adapter-axumexamples/geo-kv-prototypeexamples/geo-spin-loaderSpin defaults to off. KV selection requires a declared store, generation/hash pin, authenticated-header reader mode, and a Spin credential-variable name. A trusted proxy must replace and authenticate the original visitor IP; it does not need to supply geography. Both roots and the selected path are verified on each request. Geo errors remain application policy inputs and do not independently grant permission or select HTTP status. No automatic fallback is added.
Closes
Closes #480
Closes #486
Test plan
cargo test --workspace --all-targets(3,058 passed; nine ignored)cargo clippy --workspace --all-targets --all-features -- -D warningscargo fmt --all -- --checkcargo check --workspace --all-targets --features "fastly cloudflare spin"examples/app-demo(68 tests + three WASM checks), 32 native feature combinations, 199 tooling tests, generated consumer, and isolated serial harness (679 passed; four ignored)Additional diagnostic: native
cargo build --workspace --all-targets --all-featurescannot link Fastly SDK host imports on ARM64. The same failure is reproduced on unchanged base925fe019; the supported Fastly WASM suite passes all 362 tests using the prescribed CI runner.Checklist
CLAUDE.mdconventions{id}syntaxedgezero_coreKvRegistryLocal synthetic runtime evidence does not qualify hosted proxy protection, external backend permissions/propagation, geography accuracy or production capacity. Spin SDK reads materialize values before core validates size; guest deadlines do not certify host-side cancellation. The request-local cache repeats manifest/root reads, so operators must qualify backend latency and capacity. Publication assumes one operator per generation; ordinary read-before-write is not a distributed lock.